The sudden fallout ended a nearly yearlong partnership, during which Mr. Musk helped propel Mr. Trump to the White House and became one of the president’s top advisers.